Fix refresh request consumer invocation for web identity credentials - #7273
Draft
YuqiGuo105 wants to merge 1 commit into
Draft
Fix refresh request consumer invocation for web identity credentials#7273YuqiGuo105 wants to merge 1 commit into
YuqiGuo105 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The Consumer overload of
StsAssumeRoleWithWebIdentityCredentialsProvider.Builder.refreshRequesteagerly built anAssumeRoleWithWebIdentityRequestand delegated to the fixed-request overload. As a result, later credential refreshes reused the same request and web identity token instead of invoking the consumer again.This can cause credential refresh to fail after a dynamically supplied web identity token expires.
Fixes #5709
Modifications
Supplier.Consumerwhenever credentials are refreshed and a new request is obtained.token-1followed bytoken-2.The change is intentionally scoped to the
Consumeroverload onStsAssumeRoleWithWebIdentityCredentialsProvider. The fixed request and explicitSupplieroverloads are unchanged.Testing
./mvnw install -pl :sts -P quick -am./mvnw -pl :sts -Dtest=StsAssumeRoleWithWebIdentityCredentialsProviderTest -Dspotbugs.skip=true testtoken-1used twice.StsAssumeRoleWithWebIdentityCredentialsProviderTestpass after the change.git diff --checkcompleted successfully.Screenshots
Not applicable.
Types of changes
Checklist
mvn installsucceedsLicense
This pull request was generated with assistance from AI tools and reviewed by Yuqi Guo.