Skip to content

chore(common): remove deprecated DFSchema type-check method (Closes #23080 - partial) #23144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dodothereal wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −24
Open

chore(common): remove deprecated DFSchema type-check method (Closes #23080 - partial) #23144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions datafusion/common/src/dfschema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,30 +599,6 @@ impl DFSchema {
.all(|(dffield, arrowfield)| dffield.name() == arrowfield.name())
}

/// Check to see if fields in 2 Arrow schemas are compatible
#[deprecated(since = "47.0.0", note = "This method is no longer used")]
pub fn check_arrow_schema_type_compatible(
&self,
arrow_schema: &Schema,
) -> Result<()> {
let self_arrow_schema = self.as_arrow();
self_arrow_schema
.fields()
.iter()
.zip(arrow_schema.fields().iter())
.try_for_each(|(l_field, r_field)| {
if !can_cast_types(r_field.data_type(), l_field.data_type()) {
_plan_err!("Column {} (type: {}) is not compatible with column {} (type: {})",
r_field.name(),
r_field.data_type(),
l_field.name(),
l_field.data_type())
} else {
Ok(())
}
})
}

/// Returns true if the two schemas have the same qualified named
/// fields with logically equivalent data types. Returns false otherwise.
///
Expand Down
Loading