Skip to content

chore(common): remove deprecated DFSchema type-check method (Closes #23080 - partial)#23144

Open
Dodothereal wants to merge 1 commit into
apache:mainfrom
Dodothereal:chore/remove-deprecated-dfschema-type-check
Open

chore(common): remove deprecated DFSchema type-check method (Closes #23080 - partial)#23144
Dodothereal wants to merge 1 commit into
apache:mainfrom
Dodothereal:chore/remove-deprecated-dfschema-type-check

Conversation

@Dodothereal

Copy link
Copy Markdown
Contributor

Fixes #23080

Summary

Removes DFSchema::check_arrow_schema_type_compatible, deprecated since 47.0.0 ("This method is no longer used"). A grep across the workspace confirms zero remaining callers and zero public re-exports — the method is definition-only. The 6-major-version grace period cited by the API-health policy is past due (we are now on 55.x).

Test plan

  • git grep -nE 'check_arrow_schema_type_compatible' returns no matches in source or docs (only the removed definition site).
  • Schema is still imported at the top of dfschema.rs because it remains in use elsewhere in the file (e.g., qualified_schema_from_field_names, etc.).

AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently.

Signed-off-by: Dodothereal 129273127+Dodothereal@users.noreply.github.com

…mpatible (Closes apache#23080 - partial)

The DFSchema::check_arrow_schema_type_compatible method has been
deprecated since 47.0.0 and is definition-only — a grep across the
workspace confirms zero remaining callers and zero public re-exports.
With DataFusion now on 55.x, the 6-major-version grace period cited by
the API-health policy is past due.

AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently.

Generated-by: Anthropic Claude
Signed-off-by: Dodothereal <129273127+Dodothereal@users.noreply.github.com>
@github-actions github-actions Bot added the common Related to common crate label Jun 24, 2026
@github-actions

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-common v54.0.0 (current)
       Built [  32.741s] (current)
     Parsing datafusion-common v54.0.0 (current)
      Parsed [   0.058s] (current)
    Building datafusion-common v54.0.0 (baseline)
       Built [  32.672s] (baseline)
     Parsing datafusion-common v54.0.0 (baseline)
      Parsed [   0.060s] (baseline)
    Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.675s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron

Failed in:
  DFSchema::check_arrow_schema_type_compatible, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/33701b08b2061173c09dbab5ccffd3052a7d815f/datafusion/common/src/dfschema.rs:604

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  68.096s] datafusion-common

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change common Related to common crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old deprecated code

1 participant