Skip to content

Fix exception masking in FileSystems.matchSingleFileSpec #40109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yquaziii wants to merge 1 commit into
base: master
Choose a base branch
from
+42 −1
Open

Fix exception masking in FileSystems.matchSingleFileSpec #40109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,17 @@ public static Metadata matchSingleFileSpec(String spec) throws IOException {
if (matchResult.status() == Status.NOT_FOUND) {
throw new FileNotFoundException(String.format("File spec %s not found", spec));
} else if (matchResult.status() != Status.OK) {
// PROPOSED FIX: Extract the root cause by catching it from metadata()
IOException rootCause = null;
try {
matchResult.metadata();
} catch (IOException e) {
rootCause = e;
}
// Chain the root cause into the new IOException
throw new IOException(
String.format("Error matching file spec %s: status %s", spec, matchResult.status()));
String.format("Error matching file spec %s: status %s", spec, matchResult.status()),
rootCause);
} else {
List<Metadata> metadata = matchResult.metadata();
if (metadata.size() != 1) {
Expand Down
32 changes: 32 additions & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileSystemsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,38 @@ public class FileSystemsTest {
@Rule public ExpectedException thrown = ExpectedException.none();
private LocalFileSystem localFileSystem = new LocalFileSystem();

@Test
public void testMatchSingleFileSpecExceptionChaining() throws Exception {
java.io.IOException rootCause = new java.io.IOException("403 Forbidden: Fake GCS Error");
MatchResult failedResult = MatchResult.create(MatchResult.Status.ERROR, rootCause);

FileSystem mockFileSystem = mock(FileSystem.class);

@kennknowles kennknowles Sep 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this without mocking - e.g. by setting up a local filesystem to result in this error, or using an in-memory fake for a blobstore?

when(mockFileSystem.match(org.mockito.ArgumentMatchers.anyList()))
.thenReturn(ImmutableList.of(failedResult));

// Use reflection to temporarily override the registered filesystems
java.lang.reflect.Field field = FileSystems.class.getDeclaredField("SCHEME_TO_FILESYSTEM");
field.setAccessible(true);
@SuppressWarnings("unchecked")
java.util.concurrent.atomic.AtomicReference<java.util.Map<String, FileSystem>> ref =
(java.util.concurrent.atomic.AtomicReference<java.util.Map<String, FileSystem>>)
field.get(null);

java.util.Map<String, FileSystem> original = ref.get();
try {
ref.set(com.google.common.collect.ImmutableMap.of("dummy", mockFileSystem));

thrown.expect(java.io.IOException.class);
thrown.expectMessage("Error matching file spec dummy://fake/path: status ERROR");
thrown.expectCause(org.hamcrest.Matchers.is(rootCause));

FileSystems.matchSingleFileSpec("dummy://fake/path");
} finally {
// Restore the original registry so we don't break other tests
ref.set(original);
}
}

@Test
public void testGetLocalFileSystem() throws Exception {
// TODO: Java core test failing on windows, https://github.com/apache/beam/issues/20484
Expand Down
Loading