Conversation
Contributor
|
Assigning reviewers: R: @kennknowles for label java. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
kennknowles
reviewed
Sep 14, 2026
| java.io.IOException rootCause = new java.io.IOException("403 Forbidden: Fake GCS Error"); | ||
| MatchResult failedResult = MatchResult.create(MatchResult.Status.ERROR, rootCause); | ||
|
|
||
| FileSystem mockFileSystem = mock(FileSystem.class); |
Member
There was a problem hiding this comment.
Is there a way to test this without mocking - e.g. by setting up a local filesystem to result in this error, or using an in-memory fake for a blobstore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40076
Please add a meaningful description for your change here
Description:
This PR fixes a critical observability gap in
FileSystems.matchSingleFileSpec.Previously, if the underlying file system (such as GCS or HDFS) encountered an error and returned a
MatchResultwith anERRORstatus, the actual root-cause exception (e.g., HTTP 403 Forbidden or 500 Internal Server Error) was swallowed by the SDK.This change extracts the inner
IOExceptionfrom the failedMatchResult's.metadata()method and correctly chains it as thecausein the newly thrownIOException. This ensures the actual failure reason is exposed in the worker logs.A unit test has been added to
FileSystemsTest.javato verify the exception chaining behavior.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.