Add Point in Polygon algorithm using ray casting - #15309
Open
Clear20-22 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fixed boundary tolerance causes inconsistent near-boundary classifications and needs explicit, scale-aware, or exact handling.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a ray-casting point-in-polygon algorithm with boundary handling and doctests.
Changes:
- Adds a reusable
Pointtype and boundary helper. - Implements polygon validation and even–odd ray casting.
- Documents behavior with references and doctests.
File summaries
| File | Description |
|---|---|
geometry/point_in_polygon.py |
Adds the point-in-polygon implementation and doctests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+161
to
+162
| if is_point_on_segment(point, edge_start, edge_end): | ||
| return include_boundary |
…tolerance parameter
Member
|
ON HOLD: Our focus is on merging or closing old pull requests before October 1st. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.