Raise pdfx minimum Flutter version to 3.29.0 - #645
Merged
Conversation
The current SurfaceProducer.Callback overrides use onSurfaceAvailable and onSurfaceCleanup, which only exist from Flutter 3.27 and 3.29 respectively (onSurfaceCreated/onSurfaceDestroyed before that). The pubspec still claimed 3.24.0 as the minimum, which does not compile, matching the "overrides nothing" errors reported in issue #580. Also backfills the CHANGELOG entry for the NaN progress fix merged in #621, which was missing one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SurfaceProducer.Callbackoverrides useonSurfaceAvailable(added in Flutter 3.27) andonSurfaceCleanup(added in Flutter 3.29), so the plugin cannot actually compile against the 3.24.0 minimum it claimed, matching the "overrides nothing" compile errors reported in Object is not abstract and does not implement abstract member public abstract fun onSurfaceDestroyed(): Unit defined in io.flutter.view.TextureRegistry.SurfaceProducer.Callback #580onSurfaceCleanupback to the deprecatedonSurfaceDestroyedalias, which would still leaveonSurfaceAvailablebroken on Flutter 3.24-3.26 and reintroduce a deprecated,forRemoval=trueAPI call on newer enginesTest plan
dart format,flutter analyze --fatal-infos,flutter testall pass locally