Skip to content

Replace onSurfaceCleanup with onSurfaceDestroyed - #583

Closed
Dreamersoul wants to merge 1 commit into
ScerIO:mainfrom
Dreamersoul:patch-1
Closed

Replace onSurfaceCleanup with onSurfaceDestroyed#583
Dreamersoul wants to merge 1 commit into
ScerIO:mainfrom
Dreamersoul:patch-1

Conversation

@Dreamersoul

Copy link
Copy Markdown

@up-doc

up-doc commented May 16, 2025

Copy link
Copy Markdown

My android is broken on latest 2.9.1 until this is merged in.

Can we get this in a new version asap if possible?

@emakar

emakar commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

onSurfaceDestroyed is deprecated
update to at least 3.29

@emakar

emakar commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

may as well set minimal version for pdfx as 3.29

@vicajilau

Copy link
Copy Markdown
Member

Thanks for the report and the fix. Digging into it, this only fixes half the problem: onSurfaceCleanup is available from Flutter 3.29, but onSurfaceAvailable (also overridden here) requires Flutter 3.27, and pdfx's pubspec still claimed a 3.24.0 minimum, which never compiled against either name. Opened #645 to raise the minimum to 3.29.0 instead, so both overrides are valid and match the version we actually support. Closing this in favor of that. Appreciate the pointer to the real issue (#580).

@vicajilau vicajilau closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants