Skip to content

Deprecate console commands in DesiredGameState and allow match managers to bypass state setting #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicEastvillage merged 3 commits into from
Aug 15, 2026
Merged

Deprecate console commands in DesiredGameState and allow match managers to bypass state setting #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9337625
Deprecate console commands in DesiredGameState and allow match manage…
NicEastvillage Aug 6, 2026
53ce838
Format
NicEastvillage Aug 6, 2026
bbbec0d
Update schema
NicEastvillage Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions RLBotCS/Server/BridgeMessage/RunConsoleCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
using RLBot.Flat;

namespace RLBotCS.Server.BridgeMessage;

readonly struct RunConsoleCommand(ConsoleCommandT command) : IBridgeMessage
{
public void HandleMessage(BridgeContext context)
{
context.MatchCommandQueue.AddConsoleCommand(command.Command);
}
}
10 changes: 9 additions & 1 deletion RLBotCS/Server/BridgeMessage/SetGameState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using RLBot.Flat;
using Microsoft.Extensions.Logging;
using RLBot.Flat;
using RLBotCS.Conversion;

namespace RLBotCS.Server.BridgeMessage;
Expand All @@ -7,6 +8,13 @@ readonly struct SetGameState(DesiredGameStateT GameState) : IBridgeMessage
{
public void HandleMessage(BridgeContext context)
{
if (GameState.ConsoleCommands.Count > 0)
{
context.Logger.LogWarning(
"Running console commands through the DesiredGameState message is deprecated. "
+ "Use the ConsoleCommand message type instead."
);
}
foreach (var command in GameState.ConsoleCommands)
context.MatchCommandQueue.AddConsoleCommand(command.Command);

Expand Down
10 changes: 9 additions & 1 deletion RLBotCS/Server/FlatBuffersSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,21 @@ await _bridge.WriteAsync(
break;

case InterfaceMessage.DesiredGameState:
if (!_stateSettingIsEnabled)
if (!_stateSettingIsEnabled && _agentId != "")

@VirxEC VirxEC Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always allowing console commands is one thing, but always allowing state setting when it's supposed to be off is something else imo. I thought the point of splitting off console commands was to allow them to be used by match managers even when state setting is disabled, without letting them do state setting?

@NicEastvillage NicEastvillage Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo match managers are allowed to do anything. It's their match.

The splitting was just to clean up the API.

break;

var desiredGameState = msg.MessageAsDesiredGameState().UnPack();
await _bridge.WriteAsync(new SetGameState(desiredGameState));
break;

case InterfaceMessage.ConsoleCommand:
if (!_stateSettingIsEnabled && _agentId != "")
break;

var command = msg.MessageAsConsoleCommand().UnPack();
await _bridge.WriteAsync(new RunConsoleCommand(command));
break;

case InterfaceMessage.RenderingStatus:
var renderingStatus = msg.MessageAsRenderingStatus().UnPack();
await _rlbotServer.WriteAsync(new UpdateRenderingStatus(renderingStatus));
Expand Down
2 changes: 1 addition & 1 deletion flatbuffers-schema
Open in desktop
Submodule flatbuffers-schema updated 3 files
+1 −0 schema/gamestatemanip.fbs
+4 −0 schema/interfacepacket.fbs
+1 −1 schema/matchconfig.fbs
Loading