Deprecate console commands in DesiredGameState and allow match managers to bypass state setting - #177
Merged
Conversation
…s to bypass state setting
VirxEC
reviewed
Aug 12, 2026
|
|
||
| case InterfaceMessage.DesiredGameState: | ||
| if (!_stateSettingIsEnabled) | ||
| if (!_stateSettingIsEnabled && _agentId != "") |
Collaborator
There was a problem hiding this comment.
Always allowing console commands is one thing, but always allowing state setting when it's supposed to be off is something else imo. I thought the point of splitting off console commands was to allow them to be used by match managers even when state setting is disabled, without letting them do state setting?
Contributor
Author
There was a problem hiding this comment.
Imo match managers are allowed to do anything. It's their match.
The splitting was just to clean up the API.
Collaborator
|
other than that, LGTM |
VirxEC
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses changes in RLBot/flatbuffers-schema#63
Resolves #176