Conversation
MOVEIT_PRO_CAMERA_RENDERER picks mujoco (the default), nyx, or both. The robot description resolves the MuJoCo camera and point-cloud rates from it and runtime.launch.xml reads the same variable to decide whether to start picknik_nyx_renderer, so the two halves cannot disagree. The point-cloud rate has to follow the render rate rather than stand alone: the cloud timer publishes what the render timer produced, so running it against a stopped renderer reports every camera as never having rendered. Nyx has no depth output, so selecting it gives up point clouds. An unrecognized value fails the description rather than leaving the config with no cameras and no explanation. Needs the Nyx renderer package, which is not in a released image yet, so anything other than the default requires a moveit_pro build that carries it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YCk2yNsEQkVUSvhAmsJ4m
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
needs: moveit_pro/#22738
Motivation
moveit_progains an optional path-traced camera renderer (PickNikRobotics/moveit_pro#22738). Nothing in that repository starts it, by design — a configuration has to ask for it. This wireslab_simup to ask.Brief description
One environment variable,
MOVEIT_PRO_CAMERA_RENDERER, selects which renderer produceslab_sim's camera topics:mujoco<camera>/color. The default, and the only option on an image carrying no Nyx runtime — every arm64 image and the amd64 CPU image.nyx<camera>/nyx_color. MuJoCo's camera and point-cloud rates go to 0.bothThe same variable drives both halves —
picknik_ur.xacroresolves the MuJoCoros2_controlrates,runtime.launch.xmldecides whether to include the Nyx node — so the description and the launch file cannot disagree about which renderer is running.Two details worth a reviewer's attention:
point_cloud_publish_ratefollowsrender_publish_raterather than standing alone. The cloud timer publishes what the render timer produced (mujoco_system.cpp:1165), so zeroing only the render rate leaves a cloud timer running against a stopped renderer, reporting every camera as never having rendered, forever. Nyx has no depth output, so selectingnyxgives up point clouds — the same reason the new topic is additive rather than a replacement.dict(...)by the value, which raises naming both the bad value and the expression. (A{...}literal cannot be used here: xacro's${...}scanner stops at the first}and reports'{' was never closed.)How it was tested
pre-commit runon both changed files — green.prettierreformatsruntime.launch.xml;.xacrois not matched by that hook.mujoco,nyx, andbothresolve to the intended rates, andbogusfails witherror: 'bogus'naming the value.$(eval '"$(var x)" in ("a","b")')) and the nested$(env USER_WS $(env HOME)/user_ws)default were each proved under ROS 2 Jazzy.find-pkg-share picknik_nyx_rendereris not yet verified end to end: the package exists in no published image until moveit_pro#22738 merges. That is what theneeds:line above is for.🤖 Generated with Claude Code