Add user-triggered refresh from upstream tags - #958
Draft
picknik-johnny-5-bot[bot] wants to merge 4 commits into
Draft
picknik-johnny-5-bot[bot] wants to merge 4 commits into
picknik-johnny-5-bot[bot] wants to merge 4 commits into
Conversation
picknik-johnny-5-bot
Bot
requested review from
JWhitleyWork,
davetcoleman and
griswaldbrooks
September 15, 2026 21:55
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
Consider whether the change should land upstream in Overlapping files
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Motivation
Add an optional, quicker command for eligible upstream releases alongside the existing manual vendored-dependency workflow. Split from #894 to keep its validator and CI repairs separate.
Stacked on #894 (
fix/887-review-findings). This diff contains only the refresher, its tests, and README instructions. Retarget tomainafter #894 merges.Brief description
allor a vendored dependency directory name, not a robot configuration.Remaining manual cases include ambiguous inventory changes, unsupported LFS transitions, divergent binary patches, and checkout line-ending normalization.
allcan apply independent successes while returning nonzero for failures. Writes are not crash-atomic across files. No real vendored dependency is upgraded by this PR.The code cleanup reuses the ledger content comparison, deduplicates old inventory ancestors before filesystem checks, and shares fixture pin setup without removing assertions. The latest README-only correction restores every original byte from the stacked base and appends the quick-refresh instructions without replacing the manual workflow.
How it was tested
Published candidate:
8f11250a7d06a3a4302755bf6fe7534e1af9786f. Stacked base and merge-base:b277487ff665a01c96c56c8be5b978b1136ac9e7.Fresh README-only validation at this candidate:
README.mdchanged since reviewed code headc3d25348f05a5f25c5561f4f02688b6ff19fd548: 17 additions, zero deletions. No runtime or source changes.git diff --checkpassed.code-revieweranddocumentation-botgates passed with no findings. Both independently checked byte preservation, the optional-alternative wording, and command documentation against unchanged implementation, and executed CLI help. These were independent Hermes CLI workers in isolated worktrees, not Claude invocations; both processes finished.Earlier code validation, not rerun or relabeled as fresh README-candidate execution:
c3d25348f05a5f25c5561f4f02688b6ff19fd548: fullbin/testspassed all 183 tests, including 51 refresher cases using disposable Git/LFS repositories. Offline validation passed for 9 vendored sources and 2 optional ML submodules.8edfeb6c4c6a9c975c3232f67e4554ac3e4eced1: a Feetech dry-run using GitHub App authentication selected tag0.2.2, already current. No real snapshot writes; not rerun for this documentation-only correction.Remote CI is separate. The stacked base name
fix/887-review-findingsis known to produce an invalid integration Docker tag; that unrelated CI issue is not repaired here, and CI is not claimed green.Release notes
Enhancement: Added a user-triggered command to refresh vendored workspace dependencies from eligible upstream release tags, with a dry-run preview.
Claude agent checks
These rows describe the fresh README-only delta at
8f11250a7d06a3a4302755bf6fe7534e1af9786f; earlier code-domain evidence is bound to its original SHA above.code-reviewer: exact-SHA documentation correction; no findings.documentation-bot: explicitly requested exact-SHA documentation gate; no findings.platform-architect-bot: README prose only; no backend, ROS, build, CI, or architecture code change.frontend-noah-bot: no frontend change.security-auditor: no security-sensitive implementation or configuration change.roboticist-bot: no robotics runtime change.licensing-privacy-bot: no third-party source, attribution, or runtime data-flow change.compatibility-bot: no public API or frontend/backend contract change.sonar-bot: no analyzed source or analysis-configuration change.test-runner: recorded last, after both independent reviewers finished; this delta contains no buildable or testable code. Fresh README checks and earlier code-test evidence are listed separately above.Unattended or scheduled synchronization remains outside this PR and needs a separately scoped issue.