Skip to content

fix: rustfmt overlay coords and skip POSIX 0600 on Windows #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abrichr merged 1 commit into from
Sep 2, 2026
Merged

fix: rustfmt overlay coords and skip POSIX 0600 on Windows #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src-tauri/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ pub fn set_control_overlay_layout(app: AppHandle, layout: String) -> Result<(),
.map_err(|error| format!("could not stage the control overlay: {error}"))?;
window
.set_position(Position::Physical(PhysicalPosition::new(
position.x,
position.y,
position.x, position.y,
)))
.map_err(|error| format!("could not place the overlay stage: {error}"))?;
}
Expand Down
8 changes: 6 additions & 2 deletions tests/test_engine/test_authoring_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from __future__ import annotations

import json
import os
import stat
from pathlib import Path
from types import SimpleNamespace
Expand Down Expand Up @@ -403,8 +404,11 @@ def test_node_table_is_mode_0600(tmp_path: Path) -> None:
runner.allow()
runner._observe()
assert runner._node_table is not None
mode = stat.S_IMODE(runner._node_table._path.stat().st_mode)
assert mode == 0o600
path = runner._node_table._path
assert path.is_file()
# NTFS does not report POSIX 0o600. Production already skips fchmod there.
if os.name != "nt":
assert stat.S_IMODE(path.stat().st_mode) == 0o600


def test_projector_drops_value_title_and_six_digit_names(tmp_path: Path) -> None:
Expand Down