fix: rustfmt overlay coords and skip POSIX 0600 on Windows - #156
Merged
Conversation
rustfmt wants PhysicalPosition args on one line. NTFS does not report POSIX 0o600, so keep that assertion off Windows. The node table file still has to exist on every OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main HEAD
bacfc6cfis red on Test and Build, sodesktop-v0.16.0can't cut. Two small misses from #153 and #154.rustfmt wants the overlay stage position as
position.x, position.yon one line. #153 wrapped them.cargo fmt --checkis clean after this.test_node_table_is_mode_0600asserts POSIX0o600. On NTFS that comes back as0o666(438 == 384). Production already skipsfchmodwhenos.name == "nt". The test now only asserts the mode off Windows, and still requires the node table file to exist.Do not retag
0.15.0. Do not dispatch Release or Native Installer Release until Test and Build are green on the merged SHA.Merged by an agent session, not the founder.