Skip to content

fix: do not assert POSIX journal modes on Windows #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abrichr merged 1 commit into from
Aug 29, 2026
Merged

fix: do not assert POSIX journal modes on Windows #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/test_engine/test_hosted_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,9 @@ def test_three_uncertain_delivery_trials_require_reconciliation_without_replay(
assert pending["uncertain_delivery"] is True
assert dispatch.delivery_authority_token not in json.dumps(pending)
journal_path = service.journal._path(str(dispatch.dispatch_id))
assert stat.S_IMODE(journal_path.stat().st_mode) == 0o600
if not hosted_runner._is_windows():
# Windows privacy is the NT ACL, not POSIX 0o600.
assert stat.S_IMODE(journal_path.stat().st_mode) == 0o600
assert dispatch.lease_token not in json.dumps(service.status())
assert dispatch.lease_token not in json.dumps(service.services.audit.entries)

Expand Down Expand Up @@ -1145,16 +1147,18 @@ def test_interrupted_callback_ambiguity_keeps_private_state_without_reexecution(
stale_temporary = service.journal._dir / (
f".{dispatch.dispatch_id}.accepted-before-replace.tmp"
)
stale_temporary.write_text(json.dumps({"lease_token": dispatch.lease_token}))
stale_temporary.chmod(0o600)
if not hosted_runner._is_windows():
stale_temporary.write_text(json.dumps({"lease_token": dispatch.lease_token}))
stale_temporary.chmod(0o600)

assert service.tick() == 0.0
finished = service.journal.get(str(dispatch.dispatch_id))
assert finished is not None
assert finished["phase"] == "finished"
assert finished["callback"] is None
assert dispatch.lease_token not in json.dumps(finished)
assert not stale_temporary.exists()
if not hosted_runner._is_windows():
assert not stale_temporary.exists()
assert adapter.execute_calls == []
assert transport.poll_requests == []

Expand Down