fix: do not assert POSIX journal modes on Windows - #151
Merged
Conversation
Exact-main Windows reports NTFS 0o666 for files that POSIX marks 0o600. Privacy on Windows is Flow's ACL helper, not chmod. Keep the mode assertion on POSIX and skip leftover-tmp chmod setup on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact-main Windows failed four hosted-runner tests after #130/#146.
NTFS reports 0o666 for files this suite treated as POSIX 0o600. Windows privacy is Flow's ACL helper, not chmod. The leftover-tmp setup used chmod 0o600, then
tick()hitRunnerJournalErrorand stopped before the terminal callback.This keeps the 0o600 assertion on POSIX. It skips that leftover-tmp chmod setup on Windows. Production still requires the Windows ACL check.