chore(agentic-ci): declare rich dependency in data-designer-engine - #859
Open
github-actions[bot] wants to merge 2 commits into
Open
chore(agentic-ci): declare rich dependency in data-designer-engine#859github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
engine/validation.py imports rich at module level but the package does not declare it; it is only guaranteed transitively via data-designer-config. Add the specifier copied from the sibling config/interface packages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Greptile SummaryThe PR makes the engine’s existing Rich runtime dependency explicit and updates its lockfile package metadata accordingly.
|
| Filename | Overview |
|---|---|
| packages/data-designer-engine/pyproject.toml | Adds the same compatible Rich constraint already used by sibling packages. |
| uv.lock | Adds matching engine dependency metadata without changing the resolved Rich version or any other package version. |
Reviews (2): Last reviewed commit: "Merge branch 'main' into agentic-ci/chor..." | Re-trigger Greptile
Contributor
|
/authorize-agentic-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
packages/data-designer-engine/src/data_designer/engine/validation.pyimportsrichat module scope (from rich import box,from rich.console import ...,etc.) as runtime code, but the engine package does not declare
richin itsdependency list. Today the import only works because
data-designer-config(a mandatory workspace dependency) declares
richand installs ittransitively.
This PR closes the metadata-hygiene gap by declaring
richdirectly on thepackage that imports it, copying the specifier already used by the sibling
data-designer-configanddata-designerpackages.🔄 Changes
rich>=13.7.1,<15topackages/data-designer-engine/pyproject.toml's dynamic-versioningdependency list, inserted in alphabetical order and matching the existing
specifier style.
uv.lockviamake install-dev(addsrichto the engine'sresolved + requires-dist entries only).
🧪 Testing
uv lock --check— up to datemake test-engine— 2257 passedNotes
Specifier copied verbatim from the sibling packages that already declare
rich>=13.7.1,<15; no version selection or judgement involved. Low severity —standalone install is not currently broken because
data-designer-configguarantees
rich; this is a direct-declaration hygiene fix.🤖 Generated with Claude Code