Skip to content

chore(agentic-ci): declare rich dependency in data-designer-engine - #859

Open
github-actions[bot] wants to merge 2 commits into
mainfrom
agentic-ci/chore/dependencies-20260811-engine-rich
Open

chore(agentic-ci): declare rich dependency in data-designer-engine#859
github-actions[bot] wants to merge 2 commits into
mainfrom
agentic-ci/chore/dependencies-20260811-engine-rich

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

📋 Summary

packages/data-designer-engine/src/data_designer/engine/validation.py imports
rich at module scope (from rich import box, from rich.console import ...,
etc.) as runtime code, but the engine package does not declare rich in its
dependency list. Today the import only works because data-designer-config
(a mandatory workspace dependency) declares rich and installs it
transitively.

This PR closes the metadata-hygiene gap by declaring rich directly on the
package that imports it, copying the specifier already used by the sibling
data-designer-config and data-designer packages.

🔄 Changes

  • Add rich>=13.7.1,<15 to
    packages/data-designer-engine/pyproject.toml's dynamic-versioning
    dependency list, inserted in alphabetical order and matching the existing
    specifier style.
  • Regenerate uv.lock via make install-dev (adds rich to the engine's
    resolved + requires-dist entries only).

🧪 Testing

  • uv lock --check — up to date
  • make test-engine — 2257 passed

Notes

Specifier copied verbatim from the sibling packages that already declare
rich>=13.7.1,<15; no version selection or judgement involved. Low severity —
standalone install is not currently broken because data-designer-config
guarantees rich; this is a direct-declaration hygiene fix.

🤖 Generated with Claude Code

engine/validation.py imports rich at module level but the package does
not declare it; it is only guaranteed transitively via data-designer-config.
Add the specifier copied from the sibling config/interface packages.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions
github-actions Bot requested a review from a team as a code owner August 11, 2026 08:31
@github-actions github-actions Bot added agentic-ci Created by agentic-ci automation agentic-ci/dependencies Agentic CI - dependencies suite labels Aug 11, 2026
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes the engine’s existing Rich runtime dependency explicit and updates its lockfile package metadata accordingly.

  • Adds rich>=13.7.1,<15 to data-designer-engine.
  • Records the matching direct dependency and distribution requirement in uv.lock.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/data-designer-engine/pyproject.toml Adds the same compatible Rich constraint already used by sibling packages.
uv.lock Adds matching engine dependency metadata without changing the resolved Rich version or any other package version.

Reviews (2): Last reviewed commit: "Merge branch 'main' into agentic-ci/chor..." | Re-trigger Greptile

@andreatnvidia

Copy link
Copy Markdown
Contributor

/authorize-agentic-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-ci/dependencies Agentic CI - dependencies suite agentic-ci Created by agentic-ci automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant