NW|26-JUI-SDC|Ahmad Hmedan|Sprint 5 |Prep exercises

[AhmadHmedann]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

DONE

Task ID: CYF-1155

[LonMcGregor]

Good work on this, I have some comments for the laptop allocation task

[LonMcGregor]

Good explanations

[LonMcGregor]

If you have a question like this, what is the user expected to do? Is there some way for them to answer the question / change the outcome of the program?

[AhmadHmedann]

Thank you for the feedback, You're right_ the original version asked the question and do not let the user to respond, so it couldn't affect the program's behaviour.

I have updated the code so the user can answer Y/N, If they accept the program will assigns them a laptop with the most available OS; otherwise, it keeps their original choice or exit if there is no suitable laptops is available

[LonMcGregor]

Is there any input validation here? What is the UX like if something goes wrong?

[AhmadHmedann]

Thanks for the feedback. I added a loop to validate the user's input. If the user enters an invalid choice, the program displays a message telling them they must enter a number between 1 and 3, then keeps asking until they enter a valid option. I think this provides a better user experience than letting the program continue with invalid input.

[LonMcGregor]

This is better, having an input loop is much better UX. Does your input loop properly handle all possible inputs? (hint: what if I accidentally type something totally invalid?)

[AhmadHmedann]

You're right. At the moment, it only handles invalid numbers outside the valid range. If the user enters something like a letter, int() raises a ValueError.
I think for better validation I should use try catch.