Skip to content

fix(awm): tighten mpc response codecs #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavjain97 wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −12
Open

fix(awm): tighten mpc response codecs #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c5f998
refactor(awm): tighten mpc finalize response codec
pranavjain97 Aug 6, 2026
e37d7fb
refactor(awm): enforce exact response codecs across mpc endpoints
pranavjain97 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/__tests__/api/advancedWalletManager/mpcFinalize.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ describe('MPC Finalize', () => {

// Assert the response structure
result.should.have.property('statusCode', 200);
result.body.should.have.property('combinedKey');
result.body.should.not.have.property('combinedKey');
result.body.should.have.property('source', 'user');
result.body.should.have.property(
'commonKeychain',
Expand Down Expand Up @@ -489,7 +489,7 @@ describe('MPC Finalize', () => {
});

result.should.have.property('statusCode', 200);
result.body.should.have.property('combinedKey');
result.body.should.not.have.property('combinedKey');
result.body.should.have.property('source', 'backup');
result.body.should.have.property(
'commonKeychain',
Expand Down
1 change: 0 additions & 1 deletion src/advancedWalletManager/handlers/eddsaMPCWalletGenerationFinalize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ export async function eddsaFinalize(req: AwmApiSpecRouteRequest<'v1.mpc.key.fina
}

return {
combinedKey,
counterpartyKeyShare: sourceToCounterPartyKeyShare,
source,
commonKeychain,
Expand Down
20 changes: 11 additions & 9 deletions src/advancedWalletManager/routers/advancedWalletManagerApiSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,11 @@ const RecoveryMpcRequest = {
export type RecoveryMpcRequest = typeof RecoveryMpcRequest;

const RecoveryMpcResponse: HttpResponse = {
200: t.type({
txHex: t.string,
}), // the full signed tx
200: t.exact(
t.type({
txHex: t.string,
}),
), // the full signed tx
...ErrorResponses,
};

Expand Down Expand Up @@ -198,7 +200,7 @@ const MpcInitializeResponse = {
bitgoPayload: KeyShareType,
counterPartyKeyShare: optional(KeyShareType),
};
const MpcInitializeResponseType = optionalized(MpcInitializeResponse);
const MpcInitializeResponseType = t.exact(optionalized(MpcInitializeResponse));
export type MpcInitializeResponseType = t.TypeOf<typeof MpcInitializeResponseType>;

const BitGoKeychainType = t.type({
Expand Down Expand Up @@ -228,7 +230,7 @@ const MpcFinalizeResponse = {
source: t.union([t.literal('user'), t.literal('backup')]),
commonKeychain: t.string,
};
const MpcFinalizeResponseType = optionalized(MpcFinalizeResponse);
const MpcFinalizeResponseType = t.exact(optionalized(MpcFinalizeResponse));
export type MpcFinalizeResponseType = t.TypeOf<typeof MpcFinalizeResponseType>;

const MpcV2InitializeRequest = {
Expand All @@ -242,7 +244,7 @@ const MpcV2InitializeResponse = {
encryptedData: t.string,
encryptedDataKey: t.string,
};
const MpcV2InitializeResponseType = t.type(MpcV2InitializeResponse);
const MpcV2InitializeResponseType = t.exact(t.type(MpcV2InitializeResponse));
export type MpcV2InitializeResponseType = t.TypeOf<typeof MpcV2InitializeResponseType>;

export type MpcV2RoundState = {
Expand Down Expand Up @@ -276,7 +278,7 @@ const MpcV2RoundResponse = {
broadcastMessage: optional(t.any),
p2pMessages: optional(MpcV2RoundMessage),
};
const MpcV2RoundResponseType = optionalized(MpcV2RoundResponse);
const MpcV2RoundResponseType = t.exact(optionalized(MpcV2RoundResponse));
export type MpcV2RoundResponseType = t.TypeOf<typeof MpcV2RoundResponseType>;

const MpcV2FinalizeRequest = {
Expand All @@ -293,7 +295,7 @@ const MpcV2FinalizeResponse = {
commonKeychain: t.string,
source: t.union([t.literal('user'), t.literal('backup')]),
};
const MpcV2FinalizeResponseType = t.type(MpcV2FinalizeResponse);
const MpcV2FinalizeResponseType = t.exact(t.type(MpcV2FinalizeResponse));
export type MpcV2FinalizeResponseType = t.TypeOf<typeof MpcV2FinalizeResponseType>;

const MpcV2RecoveryRequest = {
Expand All @@ -307,7 +309,7 @@ const MpcV2RecoveryResponse = {
txHex: t.string,
stringifiedSignature: t.string,
};
const MpcV2RecoveryResponseType = t.type(MpcV2RecoveryResponse);
const MpcV2RecoveryResponseType = t.exact(t.type(MpcV2RecoveryResponse));
export type MpcV2RecoveryResponseType = t.TypeOf<typeof MpcV2RecoveryResponseType>;

// API Specification
Expand Down
Loading