fix(awm): tighten mpc response codecs - #261
Open
pranavjain97 wants to merge 2 commits into
Open
Conversation
Drop combinedKey from the EdDSA MPC finalize handler return. It's an intermediate value from keyCombine that isn't consumed by any caller (MBE only reads commonKeychain and counterpartyKeyShare), and it was passing through io-ts identity encoding on the non-exact response codec. Wrap MpcFinalizeResponseType in t.exact so the codec matches the declared contract at the JSON boundary. Tests updated accordingly. WCN-1926
Wrap the remaining AWM MPC response codecs in t.exact so any undeclared fields are stripped at the JSON boundary. Applies to initialize/finalize for v1 and v2, plus mpc recovery. SignMpc union is intentionally left as non-exact because its branches use t.any field codecs; tightening those requires narrowing the field shapes and is tracked separately.
danielpeng1
approved these changes
Aug 6, 2026
s84krish
approved these changes
Aug 6, 2026
Contributor
|
lgtm; add description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combinedKeyfrom the EdDSA MPC finalize handler return. It's an intermediate fromkeyCombinethat's not consumed by any caller (MBE only readscommonKeychainandcounterpartyKeyShare).t.exactso encoded responses match their declared contracts. Covers v1/v2 initialize/finalize and mpc recovery.SignMpcResponseunion left as-is — itst.anyfield codecscause union-match regression when wrapped strictly; tracked separately.
Ticket: WCN-1926