fix(ruby): adjust specifity of word characters - #336
Open
AlternateRT wants to merge 1 commit into
Open
AlternateRT wants to merge 1 commit into
AlternateRT wants to merge 1 commit into
Conversation
Only treat `!` and `?` as word characters when used in identifiers, symbols, hash key symbols, or the `defined?` method
vitallium
reviewed
Sep 20, 2026
vitallium
left a comment
vitallium
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! I left just one suggestion about extending the capture to support more scenarios. Happy to hear your thoughts.
Side note: I think we have an issue with our CI configuration, as I’m pretty sure the changes in this PR should cause our snapshot tests to fail.
Comment on lines
+6
to
+11
| [ | ||
| (identifier) | ||
| (simple_symbol) | ||
| (hash_key_symbol) | ||
| "defined?" | ||
| ] @identifier |
Collaborator
There was a problem hiding this comment.
suggestion: should we also add delimited_symbol and bare_symbol to handle use cases like :"ready?" or symbol arrays?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only treat
!and?as word characters when used in identifiers, symbols, hash key symbols, or thedefined?method