Constituency parse probabilities bug - #153
Open
etsipidi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank for this library! I'm using the constituency parser and its probabilities, and I noticed that while the parse trees are correct, there seems to be a bug in the returned probabilities. The probabilities matrices are missing a necessary row and column each (the column being the rightmost column, which holds the 'S' start symbol) and because of that, the matrices are currently not matching the parse trees.
The issue is in this line:
parser/supar/models/const/crf/parser.py
Line 124 in bebdd35
and I'm proposing this fix: