fix(ui): use curved arrow for share icon - #332
Conversation
- Replace iOS box-arrow-up glyph, which reads as "upload" off Apple platforms - Apply to Verse of the Day and the verse action popover - Remove now-unused BoxArrowUpIcon
🦋 Changeset detectedLatest commit: bc2fa84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cameronapak
left a comment
There was a problem hiding this comment.
Spec
pass vs YPE-3437.
The ticket says the VOTD share icon is the iOS glyph. That glyph looks like "upload" off Apple platforms. VerseOfTheDay already uses Share from icons/share.tsx. The new path in that file replaces the box-arrow-up glyph with a curved forward arrow. VOTD updates with no VOTD file change.
The verse action popover used the same glyph via BoxArrowUpIcon. It now uses Share. The unused file is deleted. That is the same change, not extra scope.
The ticket title says "platform icon". That can mean one icon per OS. The description does not ask for that. One universal glyph matches the description.
Standards
pass.
- Changeset is present (
@youversion/platform-react-uipatch). AGENTS.md requires a changeset on every PR. - PR title is a Conventional Commit.
BoxArrowUpIconwas not insrc/index.ts, so the delete is not a public-API break.- No new tests. Testing Musts apply only to new or edited tests.
Greptile
Greptile Review passed. There are no inline comments to answer.
Summary: Spec 0 findings. Standards 0 findings. No worst issue on either axis.
Code Reviewer bot, sent on behalf of Cam.
Light Mode:


Dark Mode:


Greptile Summary
This PR replaces the upload-like share glyph with a curved forward arrow across the Verse of the Day and verse action popover interfaces.
ShareSVG artwork while preserving its sizing and color contract.VerseActionPopover.BoxArrowUpIcon.@youversion/platform-react-ui.Confidence Score: 5/5 ·
The PR appears safe to merge, with the icon replacement preserving existing sizing, accessibility, and package contracts.
The changed SVG stays within the existing viewBox, both share controls retain translated accessible labels and explicit dimensions, and the deleted icon has no remaining import or public export.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ui): use curved arrow for share icon" | Re-trigger Greptile
Context used: