Skip to content

fix(ui): use curved arrow for share icon - #332

Merged
bmanquen merged 1 commit into
mainfrom
bm/YPE-3437-update-share-icon-to-reflect-platform-icon
Aug 13, 2026
Merged

fix(ui): use curved arrow for share icon#332
bmanquen merged 1 commit into
mainfrom
bm/YPE-3437-update-share-icon-to-reflect-platform-icon

Conversation

@bmanquen

@bmanquen bmanquen commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator
  • Replace iOS box-arrow-up glyph, which reads as "upload" off Apple platforms
  • Apply to Verse of the Day and the verse action popover
  • Remove now-unused BoxArrowUpIcon

Light Mode:
CleanShot 2026-08-12 at 21 54 33@2x
CleanShot 2026-08-12 at 21 55 40@2x

Dark Mode:
CleanShot 2026-08-12 at 21 55 04@2x
CleanShot 2026-08-12 at 21 55 25@2x

Greptile Summary

This PR replaces the upload-like share glyph with a curved forward arrow across the Verse of the Day and verse action popover interfaces.

  • Updates the shared Share SVG artwork while preserving its sizing and color contract.
  • Reuses the shared icon in VerseActionPopover.
  • Removes the now-unused BoxArrowUpIcon.
  • Adds the required patch changeset for @youversion/platform-react-ui.

Confidence Score: 5/5  ·  View in Greptile

The PR appears safe to merge, with the icon replacement preserving existing sizing, accessibility, and package contracts.

The changed SVG stays within the existing viewBox, both share controls retain translated accessible labels and explicit dimensions, and the deleted icon has no remaining import or public export.

Important Files Changed

Filename Overview
packages/ui/src/components/icons/share.tsx Replaces the SVG path while retaining the existing viewBox, current-color fill, prop forwarding, and consumer sizing behavior.
packages/ui/src/components/verse-action-popover.tsx Replaces the private box-arrow icon with the shared Share icon without changing the action callback or accessible label.
packages/ui/src/components/icons/box-arrow-up.tsx Removes an internal icon with no remaining code references or public exports.
.changeset/eighty-donkeys-brake.md Correctly records the user-visible icon adjustment as a patch release.

Fix All in Greploop

Reviews (1): Last reviewed commit: "fix(ui): use curved arrow for share icon" | Re-trigger Greptile

Context used:

- Replace iOS box-arrow-up glyph, which reads as "upload" off Apple platforms
- Apply to Verse of the Day and the verse action popover
- Remove now-unused BoxArrowUpIcon
@bmanquen
bmanquen requested a review from cameronapak August 13, 2026 02:56
@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc2fa84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@youversion/platform-react-ui Patch
vite-react Patch
@youversion/platform-core Patch
@youversion/platform-react-hooks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cameronapak cameronapak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec

pass vs YPE-3437.

The ticket says the VOTD share icon is the iOS glyph. That glyph looks like "upload" off Apple platforms. VerseOfTheDay already uses Share from icons/share.tsx. The new path in that file replaces the box-arrow-up glyph with a curved forward arrow. VOTD updates with no VOTD file change.

The verse action popover used the same glyph via BoxArrowUpIcon. It now uses Share. The unused file is deleted. That is the same change, not extra scope.

The ticket title says "platform icon". That can mean one icon per OS. The description does not ask for that. One universal glyph matches the description.

Standards

pass.

  • Changeset is present (@youversion/platform-react-ui patch). AGENTS.md requires a changeset on every PR.
  • PR title is a Conventional Commit.
  • BoxArrowUpIcon was not in src/index.ts, so the delete is not a public-API break.
  • No new tests. Testing Musts apply only to new or edited tests.

Greptile

Greptile Review passed. There are no inline comments to answer.

Summary: Spec 0 findings. Standards 0 findings. No worst issue on either axis.


Code Reviewer bot, sent on behalf of Cam.

Comment thread packages/ui/src/components/icons/share.tsx
Comment thread packages/ui/src/components/verse-action-popover.tsx
@bmanquen
bmanquen merged commit 037de56 into main Aug 13, 2026
14 checks passed
@bmanquen
bmanquen deleted the bm/YPE-3437-update-share-icon-to-reflect-platform-icon branch August 13, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants