Fix successful request retry returning previous failure

[BigRoy]

Bug

Retries of REST requests can't succeed. If an attempt fails (connection error, timeout, 502, 503) and a later retry succeeds, _do_rest_request still returns the first failure.

This affects every get/post/put/... call and GraphQl queries, e.g. while the server is restarting or behind a flaky proxy.

Cause

The failure of an attempt is stored in new_response. It was never cleared, and after the retry loop:

if new_response is not None:
    return new_response

so the successful response from a later attempt was ignored.

Fix

Reset new_response = None at the start of each attempt, so only a failure of the last attempt is returned.

Reproduce

Needs an attempt to fail and the next one to succeed, so the easiest way is with a patched request function:

import requests
import ayon_api

con = ayon_api.get_server_api_connection()
orig_get = con._session_functions_mapping[ayon_api.utils.RequestTypes.get]
calls = []

def flaky_get(url, **kwargs):
    calls.append(url)
    if len(calls) == 1:
        raise requests.exceptions.ConnectionError("simulated")
    return orig_get(url, **kwargs)

con._session_functions_mapping[ayon_api.utils.RequestTypes.get] = flaky_get
response = con.get("projects")
print(len(calls), response.status_code)
# develop: 2 500   (second attempt succeeded, first failure returned)
# this PR: 2 200

Testing notes

• tests/test_request_retries.py covers a connection error and a 503 followed by success.
• Manual: restart the server while a script polls con.get("info"); requests that succeed on a retry now return data instead of an error.

🤖 Generated with Claude Code

[iLLiCiTiT]

Suggested change

	# Reset failure of previous attempt, otherwise a successful
	# retry would return the previous failure
	new_response = None
	try:
	response = function(url, **kwargs)
	try:
	response = function(url, **kwargs)
	new_response = None

[iLLiCiTiT]

I would reuse the last captured error, but we should reset it after successfull attempt. (this is big one)

[Copilot]

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Fixes request retries so a later successful attempt is returned instead of an earlier failure.

Changes:

• Clears stale failure state before each retry.
• Adds regression tests for connection errors and HTTP 503 responses.
• Adds a reusable fake response helper.

File summaries

File	Description
tests/test_request_retries.py	Verifies successful retries return successful responses.
tests/fake_transfer.py	Provides a minimal response test double.
ayon_api/server_api.py	Resets retry failure state before each attempt.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.