Instant update narrow line color - #313
Closed
remcoder wants to merge 7 commits into
Closed
Conversation
|
Visit the preview URL for this PR (updated for commit 68cf60f): https://gcode-preview--pr313-feature-instant-upda-dp2t0pgc.web.app (expires Sat, 19 Sep 2026 20:24:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
remcoder
marked this pull request as draft
August 20, 2026 20:40
Member
Author
|
Parking this PR for now. The instant color update works and is a real improvement, but the approach overlaps with the object-manager direction in #310/#311. Those PRs track meshes explicitly (O(k) direct access) instead of discovering them by scene traversal per color set (O(n) full walk), and they're the intended architecture for exactly this kind of update. If that work lands, this traversal-based code gets refactored away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Color of narrow extrusion/travel lines is updated instantly.
The way I access the travel lines and extrusion lines in the scene: