Skip to content

Instant update narrow line color - #313

Closed
remcoder wants to merge 7 commits into
developfrom
feature/instant-update-travel-lines
Closed

Instant update narrow line color#313
remcoder wants to merge 7 commits into
developfrom
feature/instant-update-travel-lines

Conversation

@remcoder

Copy link
Copy Markdown
Member

Color of narrow extrusion/travel lines is updated instantly.

The way I access the travel lines and extrusion lines in the scene:

  • .userData a reserved object on 3d objects (meshes, groups) with a custom prop for 'lineType'.
  • a function to 'query' the scene by traversing the scene graph and filtering on that lineType

@github-actions

github-actions Bot commented Sep 12, 2025

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 68cf60f):

https://gcode-preview--pr313-feature-instant-upda-dp2t0pgc.web.app

(expires Sat, 19 Sep 2026 20:24:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531

@remcoder
remcoder marked this pull request as draft August 20, 2026 20:40
@remcoder remcoder added the poc proof-of-concept. not intended te be merged into develop label Aug 20, 2026
@remcoder

Copy link
Copy Markdown
Member Author

Parking this PR for now. The instant color update works and is a real improvement, but the approach overlaps with the object-manager direction in #310/#311. Those PRs track meshes explicitly (O(k) direct access) instead of discovering them by scene traversal per color set (O(n) full walk), and they're the intended architecture for exactly this kind of update. If that work lands, this traversal-based code gets refactored away.

@remcoder remcoder closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

poc proof-of-concept. not intended te be merged into develop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant