Skip to content

Make local-player analysis stack safe - #1268

Merged
Frotty merged 1 commit into
masterfrom
codex/stack-safe-local-player-analysis
Aug 29, 2026
Merged

Make local-player analysis stack safe#1268
Frotty merged 1 commit into
masterfrom
codex/stack-safe-local-player-analysis

Conversation

@Frotty

@Frotty Frotty commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

  • replace recursive local-player IM indexing, return detection, short-circuit traversal, and loop-exit analysis with explicit worklists
  • preserve the existing dependency/control-flow model while accepting deeply nested generated IM without overflowing the JVM stack
  • retain useful exception types when compiletime failures have no message, and keep the Swing error window from opening synthetic compiler source locations as filesystem paths

Regression coverage

  • constructs 20,000 nested IM conditionals inside a loop and runs LocalPlayerContextAnalyzer
  • verifies message-less throwables report StackOverflowError instead of null
  • verifies <source of NoExpr not found> is classified as synthetic rather than a source file

Checks

  • focused local-player optimizer tests: passed
  • focused compiletime diagnostic tests: passed
  • focused error-window source test: passed
  • affected map compiled successfully with -runcompiletimefunctions -injectobjects -lua -compiletimeCache -inline -localOptimizations

The full suite was intentionally left to CI because it is expensive; all directly affected suites were run locally.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T17:44:50.906527Z fb97d30 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Frotty
Frotty merged commit aa986c6 into master Aug 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant