Skip to content

Handle detached generic static initializers - #1267

Merged
Frotty merged 1 commit into
masterfrom
codex/detached-generic-static-init
Aug 29, 2026
Merged

Handle detached generic static initializers#1267
Frotty merged 1 commit into
masterfrom
codex/detached-generic-static-init

Conversation

@Frotty

@Frotty Frotty commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve detached generic-static initializer entries as metadata during Lua specialization
  • avoid attempting tree replacement/removal for initializer nodes with no parent
  • retain ordered insertion for initializers that are attached to executable ImStmts
  • add an IM-level regression covering two concrete generic-static specializations with a detached default initializer

Verification

  • ./gradlew test --tests de.peeeq.wurstscript.translation.imtranslation.GenericTypesTests --tests tests.wurstscript.tests.LuaBackendAuditTests — passed
  • grill build in zombie-defense with the locally installed patched compiler — passed and produced Zombie_Defense_0.26i.w3x

Acceptance criteria

  • detached initializer metadata never becomes a null-parent tree insertion/removal
  • attached initializer order remains unchanged
  • concrete generic-static storage remains independent
  • the reported project builds without the post-typecheck NPE

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T16:56:33.722057Z 073f6ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Frotty
Frotty merged commit b923724 into master Aug 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant