Scalarize Lua tuples through ordered scalar bundles by Frotty · Pull Request #1265 · wurstscript/WurstScript

Frotty · 2026-08-29T09:46:06Z

Summary

run the shared IM tuple-elimination pass for Lua, lowering tuple locals, parameters, returns, fields, arrays, nesting, assignments, calls, and comparisons into ordered scalar bundles
preserve source evaluation order and failure behavior while keeping pure optimized paths free of unnecessary tuple allocations
specialize only Lua paths whose tuple-valued generic storage requires a concrete layout, using AST/node identity and explicit specialization metadata instead of emitted names
establish phase invariants at the producer: declare all specialized statics before lowering their initializers, share virtual tuple-return slots structurally, and reject residual tuple IM
document the repository-wide rule that compiler passes must repair malformed state at its source rather than reconstructing intent downstream

Correctness and performance

no Lua tuple tables, tuple-copy helpers, or tuple-equality helpers are emitted
optimized vec2 code lowers to four scalar parameters with no table construction in the function body
deterministic interpreter-vs-Lua differential coverage exercises nested tuples, selection, calls, recursion, comparison, aliasing, mutable reads, lvalue retargeting, and evaluation order
generic static ownership/type arguments are structural; the previous class-name/type-name parser and recursive fallback are removed
JASS continues using the same established tuple-elimination semantics

Focused verification

LuaBackendAuditTests
TupleTests
FastHashMapTests.tupleKeyLua
TypeClassTests
git diff --check

All focused checks pass locally. The full suite is intentionally left to CI.

Supersedes #1261. The Lua integer-ID class lowering from #1264 is already on master and this branch is based on it.

chatgpt-codex-connector · 2026-08-29T09:46:14Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-29T12:46:41.227422Z	`75065aa`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b57b7472a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T09:54:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe872697cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T10:06:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2af7430b4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T10:15:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

WurstScript/de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java

Lines 1983 to 1985 in d1763d3

    
           ImExpr rhs = origSet.getRight().copy(); 
        
           rhs = rewriteGenericGlobalsInExpr(rhs, originalClass, generics); 
        
           rhs = specializeNullInitializer(rhs, specializedType);

Remove the phantom erased static initializer

When a Lua program references only a tuple instantiation such as Box<pair>, this copies every side-effecting static initializer into the specialized global while transformGenericNewOnly leaves the original initializer in the init function. Garbage collection can remove the unread original global but deliberately preserves the initializer's side effects, so an initializer like static int value = bump() runs twice even though only one concrete instantiation exists; the Jass path removes these nonspecialized initializers. Remove the erased initializer when it has no erased instantiation, or otherwise ensure only live instantiations execute their copies.

AGENTS.md reference: AGENTS.md:L231-L235

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T10:34:40Z

Fixed the phantom erased generic-static initializer in 6d86f5f. The cleanup now runs immediately after targeted specialization, before optimization can turn the erased dead store into a standalone side effect. It uses structural specialization metadata plus deterministic fixed-point reachability: tuple-only Box initialization runs exactly once, while a genuinely live erased Box and Box each retain one initializer. Focused Lua/tuple/FastHashMap/type-class sweep passes.\n\n@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d86f5f7fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T10:46:02Z

Replaced the per-initializer deletion loop with graph mark-and-sweep in 247b0b7, including the mutually-referential erased initializer SCC regression. Focused Lua/tuple/FastHashMap/type-class tests pass.\n\n@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 247b0b7c8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T11:09:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 937ec83d33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T11:20:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 552451941c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T11:41:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f785dfa2a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T11:55:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ecd1979e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T12:22:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77619f214e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Frotty · 2026-08-29T12:39:11Z

@codex review

chatgpt-codex-connector · 2026-08-29T12:46:40Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 75065aa39e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Scalarize Lua tuples through ordered bundles

4b57b74

Frotty mentioned this pull request Aug 29, 2026

Scalarize tuples in the Lua backend #1261

Closed

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/lua/translation/LuaTranslator.java Outdated

Retain nominal metadata for tuple specializations

fe87269

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateTuples.java Outdated

Comment thread ...stscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java

Preserve tuple address order deterministically

2af7430

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateTuples.java Outdated

Preserve eager tuple comparison evaluation

d1763d3

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Remove phantom generic static initialization

6d86f5f

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/lua/translation/RemoveGarbage.java Outdated

Mark live generic static initializer graphs

247b0b7

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/lua/translation/RemoveGarbage.java

Keep initializers for live erased classes

937ec83

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/lua/translation/RemoveGarbage.java Outdated

Root erased initializers from allocations

5524519

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...stscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java Outdated

Preserve generic instanceof identity in Lua

f785dfa

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...stscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java Outdated

Preserve specialized identity in class hierarchies

1ecd197

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/WurstCompilerJassImpl.java

Comment thread ...stscript/src/main/java/de/peeeq/wurstscript/translation/imtranslation/EliminateGenerics.java

Handle tuple varargs and generic identity inheritance

77619f2

chatgpt-codex-connector Bot reviewed Aug 29, 2026

View reviewed changes

Comment thread ...urstscript/src/main/java/de/peeeq/wurstscript/translation/lua/translation/RemoveGarbage.java Outdated

Separate metadata from dispatch reachability

75065aa

Frotty merged commit 5687330 into master Aug 29, 2026
6 checks passed

Frotty deleted the codex/lua-tuple-ordered-bundles branch August 29, 2026 12:48

	ImExpr rhs = origSet.getRight().copy();
	rhs = rewriteGenericGlobalsInExpr(rhs, originalClass, generics);
	rhs = specializeNullInitializer(rhs, specializedType);

Uh oh!

Conversation

Frotty commented Aug 29, 2026

Summary

Correctness and performance

Focused verification

Uh oh!

chatgpt-codex-connector Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Frotty commented Aug 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Aug 29, 2026 •

edited

Loading