fix(user_management): honor client_id in PKCE authorization URL - #701
Merged
Conversation
…rl_with_pkce Fixes #700. get_authorization_url_with_pkce accepted a client_id argument and silently ignored it — the URL always carried the client's configured client_id, while its PKCE sibling authenticate_with_code_pkce honored the override, so multi-tenant callers got an authorization URL for one application and a token exchange for another. The generated get_authorization_url (user_management and sso) now accepts an optional client_id override that falls back to the client's configured value (regenerated from oagen-emitters), and the PKCE wrapper forwards it in both the sync and async clients. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Contributor
Greptile SummaryThe PR makes authorization URL generation honor an explicit
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix(user_management): honor client_id ov..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_authorization_url_with_pkceaccepted aclient_idargument but silently ignored it — the URL always carried the client's configuredclient_id, while its PKCE siblingauthenticate_with_code_pkcehonored the override. Multi-tenant callers got an authorization URL for one application and a token exchange for another. Fixes get_authorization_url_with_pkce accepts client_id and silently ignores it (get_jwks_url honours it) #700.get_authorization_url(in bothuser_managementandsso) now accepts an optionalclient_idoverride that falls back to the client's configured value. Those files are oagen-generated, so this part of the change was made inoagen-emittersand regenerated rather than hand-edited here.client_idin both the sync and async clients.