feat(pkce): Default clientId to the client's configured client ID - #423
Merged
Conversation
PKCEHelper's four flows (AuthKit/SSO authorization URL and code exchange) required callers to re-pass a clientId the WorkOS client already carries (constructor arg / WORKOS_CLIENT_ID). Make the parameter optional with a fallback to requireClientId(), aligning PHP with the other backend SDKs' override-with-fallback pattern. Explicit arguments still win; an unconfigured client now throws ConfigurationException instead of a TypeError. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Greptile SummaryMakes the client ID optional in all four PKCE authorization and code-exchange flows.
Confidence Score: 5/5The PR appears safe to merge. All four changed methods preserve explicit client IDs, resolve omitted values through the existing configuration guard, and pass the resolved value into the correct request field. Important Files Changed
Reviews (1): Last reviewed commit: "feat(pkce): default clientId to the clie..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$clientIdoptional across all fourPKCEHelperflows —getAuthKitAuthorizationUrl,authKitCodeExchange,getSsoAuthorizationUrl, andssoCodeExchange— falling back to$this->client->requireClientId()when omitted.WorkOSclient already carries (constructor argument orWORKOS_CLIENT_IDenv var), aligning the PHP SDK with the override-with-fallback pattern used by the other backend SDKs.ConfigurationExceptionwith a clear message instead of aTypeErrorfrom the missing required parameter.ConfigurationExceptionpath for both authorization-URL and code-exchange flows.