IDE resource handling and error-path improvements#10854
Open
rlm2002 wants to merge 4 commits into
Open
Conversation
iotsafe-raspberrypi: goto exit on cert-load failure (was return -1). MQX server: replace bare return -1 with goto exit + guarded cleanup. QNX client: correct cleanup-ladder jump targets to unwind properly. initialize ctx and ssl to NULL validate wolfIoTSafe_GetCert's int return before casting to uint32_t
Set ssl = NULL after the per-connection free so the final util_Cleanup no longer double-frees it; close(connd) on post-accept error paths.
|
retest this please |
Contributor
Author
|
Retest this please Jenkins. makedist check - stream corrupted exception, invalid stream header.
|
rlm2002
requested review from
douzzer and
wolfSSL-Fenrir-bot
and removed request for
douzzer
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10854
No scan targets match the changed files in this PR. Review skipped.
4 tasks
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes resource-cleanup bugs on error/shutdown paths across the IDE TLS examples.
connd) leak on TLS error paths.exit:.wolfIoTSafe_GetCert()negativeintreturn was cast touint32_t, change to be validated as signed before casting.Fixes #10846 and Fixes #10847
Fixes #10800