Fix ML-DSA level auto-detection in WOLFSSL_MLDSA_NO_ASN1 builds#10852
Open
stenslae wants to merge 1 commit into
Open
Fix ML-DSA level auto-detection in WOLFSSL_MLDSA_NO_ASN1 builds#10852stenslae wants to merge 1 commit into
stenslae wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10852
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Member
Author
|
Jenkins retest this please |
stenslae
force-pushed
the
fix-mldsa-privkeydecode-no-asn1
branch
from
d199622 to
8407359
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10852
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_MlDsaKey_PublicKeyDecode() couldn't auto-detect the ML-DSA security level from DER when built with WOLFSSL_MLDSA_NO_ASN1. Adds OID-to-level detection to the no-ASN.1 parser to match normal build behavior, fixes a one-byte over-read on malformed zero-length BIT STRINGs, and makes DER private-key decode explicitly return NOT_COMPILED_IN in this mode instead of behaving inconsistently.
Testing
Adds test coverage and two new CI jobs to exercise this configuration.
Checklist