fix: syncing failures - #13
Open
nicodh wants to merge 1 commit into
Open
Conversation
nicodh
added this pull request to stack #16
September 9, 2026 16:21
hpk42
approved these changes
Sep 9, 2026
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
Tested manually, and it fixes UI behaviour, so that syncing works where on main it doesnt. So i think it's ok to merge.
I think failing to apply a diff bails out and should better cause "failed to apply update" dialogue and continue.
ASFAIS IronCalc does not have a conflict resolution model. For example, when one side deletes a sheet, and the other edits in that sheet, applying the update likely fails. But then failing the app completely without giving the user access to the data at all, is worse than skipping an not-applyable update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12
It seems last_serial was set before a model exists