feat/german-language - #587
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesGerman Locale Support
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/i18n/locales/de/editor.json`:
- Around line 9-46: The German locale's annotations block uses German keys which
breaks key-path lookups; rename the top-level key "Anmerkungen" to "annotations"
and change each German key to the matching English key used in en/editor.json
(e.g. "Einstellungen" -> "settings", "aktiv" -> "active", "text" -> "text",
"image" -> "image", "arrow" -> "arrow", "blur" -> "blur", "textContent" stays
"textContent", "textPlaceholder" stays "textPlaceholder", "fontStyle" ->
"fontStyle", "selectStyle" -> "selectStyle", "size" -> "size", "toggleBold" ->
"toggleBold", "toggleItalic" -> "toggleItalic", "toggleUnderline" ->
"toggleUnderline", "alignLeft" -> "alignLeft", "alignCenter" -> "alignCenter",
"alignRight" -> "alignRight", "textColor" -> "textColor", "background" ->
"background", "none" -> "none", "clearBackground" -> "clearBackground",
"uploadImage" -> "uploadImage", "supportedFormats" -> "supportedFormats",
"arrowDirection" -> "arrowDirection", "strokeWidth" -> "strokeWidth",
"arrowColor" -> "arrowColor", "deleteAnnotation" -> "deleteAnnotation",
"shortcutsAndTips" -> "shortcutsAndTips", "tipSelectAnnotation" ->
"tipSelectAnnotation", "tipCycleForward" -> "tipCycleForward",
"tipCycleBackward" -> "tipCycleBackward", "imageUploadSuccess" ->
"imageUploadSuccess", "imageUploadError" -> "imageUploadError", "blurStrength"
-> "blurStrength", "solidColor" -> "solidColor", and "borderRadius" ->
"borderRadius"; keep the German strings as values and preserve interpolation
tokens like {{width}}/{{strength}} exactly.
In `@src/i18n/locales/de/extensions.json`:
- Line 26: The translation key "von" is a localized identifier causing lookup
failures; rename the key to the canonical English identifier (e.g., replace the
"von" key with "author") while keeping the German value "Von {{author}}", and
update any code or template lookups that referenced "von" to use "author" (or
the chosen canonical key) so runtime i18n lookups succeed; locate the "von"
entry in the locales JSON and perform the key rename consistently across the
codebase.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 294bd7a5-8d70-4187-bf12-21d22e00674a
📒 Files selected for processing (9)
src/i18n/config.tssrc/i18n/locales/de/common.jsonsrc/i18n/locales/de/dialogs.jsonsrc/i18n/locales/de/editor.jsonsrc/i18n/locales/de/extensions.jsonsrc/i18n/locales/de/launch.jsonsrc/i18n/locales/de/settings.jsonsrc/i18n/locales/de/shortcuts.jsonsrc/i18n/locales/de/timeline.json
Collaborator
|
Yes, nice PR :) always good to add some languages !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
translation from en to de
Motivation
german language is missing
Type of Change
New Feature
Test
Since i cannot test it i only can rely on code review.
Summary by CodeRabbit