Skip to content

Rerequest completion items when text is deleted/retyped - #306

Merged
waf merged 1 commit into
mainfrom
rerequest-completion-when-typed-text-does-not-match
Aug 15, 2026
Merged

Rerequest completion items when text is deleted/retyped#306
waf merged 1 commit into
mainfrom
rerequest-completion-when-typed-text-does-not-match

Conversation

@waf

@waf waf commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Type "G" to get all completions starting with "G", then backspace and press "H" -- we incorrectly used the cached completions for "G".

Instead, we now detect that the completions don't match and re-invoke the completion callback with the newly typed text.

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.7%. Comparing base (9d22b9d) to head (3743622).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #306   +/-   ##
=====================================
  Coverage   86.7%   86.7%           
=====================================
  Files         48      48           
  Lines       4130    4131    +1     
  Branches     686     685    -1     
=====================================
+ Hits        3582    3583    +1     
  Misses       381     381           
  Partials     167     167           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waf
waf merged commit 99eea64 into main Aug 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant