docs(useStorage): recipe for surfacing failed writes - #904
Merged
Conversation
Adapter wrap is the composition point — no onError hook.
johnleider
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes are fire-and-forget inside a deep watcher, so
storage.setcannot reject and anonErrorfactory option would be a new callback family the rest of the plugin layer does not use.The composition point is the adapter — wrap
setItem, record the failure, rethrow so the internal log still fires. Same move as a custom logger or notifications adapter. Theme/locale persist ride the same plugin instance.Closes #767
Closes #756