bench: keep third-party and frozen baselines out of CodSpeed - #9952
Open
connortsui20 wants to merge 1 commit into
Open
connortsui20 wants to merge 1 commit into
connortsui20 wants to merge 1 commit into
Conversation
`arrow_checked_add_u32` runs the arrow-rs checked add next to the Vortex lane kernel, and `words_gather_scalar` runs a frozen copy of the previous scalar `collect_bool` loop. Neither can regress because of a pull request, so a change in their number is never actionable, and on the walltime legs they were the three noisiest series in the suite: the arrow benchmark flipped on 64 of 97 pull requests on the neon leg alone. Both stay in the tree for local `cargo bench` comparisons. They lose `#[cpu_features]`, which takes them off the walltime legs, and gain `#[cfg(not(codspeed))]`, which keeps them out of the simulation build. Signed-off-by: Claude <noreply@anthropic.com>
This was referenced Sep 20, 2026
connortsui20
added this pull request to stack #9954
September 20, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of three stacked PRs on CodSpeed flakiness. The first resizes benchmarks, the third unifies the allocator.
The three noisiest series in the whole suite are benchmarks of code Vortex does not own or does not change:
lane_kernels.rs:arrow_checked_add_u32(neon leg)lane_kernels.rs:arrow_checked_add_u32(avx2 leg)collect_bool.rs:words_gather_scalar[65536](avx2 leg)lane_kernels.rs:arrow_checked_add_u32(avx512 leg)arrow_checked_add_u32runs the arrow-rs checked add over the same data aslanezip_checked_add_u32.words_gather_scalarruns a frozen copy of the previous scalarcollect_boolloop. Neither can regress because of a pull request, so a change in their number is never actionable, and on the walltime legs they flipped on about half of all pull requests.Changes
Both benchmarks stay in the tree for local
cargo benchcomparisons, but leave CodSpeed: they lose#[cpu_features], which takes them off the walltime legs, and gain#[cfg(not(codspeed))], which keeps them out of the simulation build. Imports and fixture fields that only they use are gated the same way. The guide gets a short section on keeping third-party and frozen baselines out of CodSpeed.The other arrow baselines (
arrow_narrow_*andarrow_widen_*inlane_kernels.rs) run in simulation, have not flipped, and are left as they are.Checks run:
cargo clippy --locked --benches -p vortex-buffer -p vortex-compute -- -D warningsRUSTFLAGS="--cfg codspeed -D warnings" cargo check --locked --benches -p vortex-buffer -p vortex-compute, to confirm the gated build has no unused itemscargo +nightly-2026-09-10 fmton the touched crates🤖 Generated with Claude Code
https://claude.ai/code/session_01B6ApyxEXpjiasZbQptsypn
Generated by Claude Code