Give spiral-engine its own series colors - #28
Closed
claude[bot] wants to merge 1 commit into
Closed
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
Only `datafusion:*` and `duckdb:*` pairs were pinned in `KEYED`, and the per-format defaults in `FORMAT` deliberately reuse datafusion's colors. Any third engine therefore fell through to `FORMAT` and drew in exactly datafusion's shade -- `spiral-engine` and datafusion were indistinguishable on every chart where both appear. Pin `spiral-engine` for the five formats datafusion also reads, each a third shade that stays clear of both the datafusion and the duckdb color and reads on the light and the dark card, and keep the existing importance-tier widths. Add a regression test asserting no spiral-engine pair shares a color with datafusion or duckdb. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sa2mGanAjiQAb16Ak8zoyp Signed-off-by: Claude <noreply@anthropic.com>
claude
Bot
force-pushed
the
fix/spiral-engine-series-color
branch
from
August 28, 2026 10:38
e77feb5 to
3733ce5
Compare
|
Vercel preview for |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Baris Palaska
Before this change, spiral-engine drew in exactly the same color as DataFusion on every chart where both engines appear, so the two lines were impossible to tell apart. Only the
datafusion:*andduckdb:*pairs were pinned inKEYED(web/lib/chart-format.ts), and the per-format defaults inFORMATdeliberately reuse DataFusion's colors — so any third engine fell through to the format default and landed on DataFusion's shade.After it, spiral-engine has its own pinned color for each of the five formats DataFusion also reads: teal for
vortex-file-compressed, pink forvortex-compact, deep sky blue forparquet, warm gray forlance, and rust forarrow. Each is a third shade that stays clear of both the DataFusion and the duckdb color for that format, keeps the existing importance-tier line widths, and is legible on the light and the dark card, with the hue steps chosen so the pairs also separate under the common red-green color-vision deficiencies. A new test inchart-format.test.tsasserts that no spiral-engine pair shares a color with DataFusion or duckdb, so a future engine cannot silently reintroduce the collision.Format check, lint,
tsc --noEmit, and the full vitest suite pass locally (the Postgres integration file self-skips without Docker).Generated by Claude Code