Skip to content

Split random access summaries into hot/cold - #26

Merged
lwwmanning merged 8 commits into
developfrom
wm/random-access-hot-cold
Aug 27, 2026
Merged

lwwmanning merged 8 commits into
developfrom
wm/random-access-hot-cold

Conversation

@lwwmanning

@lwwmanning lwwmanning commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Split the Random Access summary into Hot and Cold panels. Each panel ranks formats independently from dataset-grouped results and reports the arithmetic mean across datasets. Hot reuses an accessor after a one-second untimed warm-up. Cold includes file open and metadata parsing in each timed take. It does not clear the OS page cache. Charts label both modes and use dashed lines for Cold results. Write Throughput now reports aggregate values in MB/s, while Scan Throughput remains in GB/s.

This depends on Vortex PR #9631 for the mode definitions and PR #9649 for the open_mode producer and ingest path. Migration 010 marks historical rows as cached, and schema version 3 coordinates the deployment.

Signed-off-by: Will Manning <will@willmanning.io>
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Vercel preview for ac9edafcbd7f0122ac1f1dbc3332fa05fb6ada77: https://benchmarks-website-3megk8n8c-vortex-data.vercel.app

Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
@github-actions
github-actions Bot requested a deployment to preview August 27, 2026 16:26 In progress
Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning
lwwmanning marked this pull request as ready for review August 27, 2026 16:59
@lwwmanning
lwwmanning enabled auto-merge (squash) August 27, 2026 16:59
@lwwmanning lwwmanning changed the title Split random access summaries by access mode Split random access summaries into hot/cold Aug 27, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 615b19c3d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/lib/data-cache.ts
* It is independent of the producer-facing benchmark schema version.
*/
const GROUP_PAYLOAD_CACHE_VERSION = 'v7';
const GROUP_PAYLOAD_CACHE_VERSION = 'v8';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Version the standalone chart payload cache

The random-access chart wire shape now changes from format-only series to format:hot/format:cold, but this bump versions only the group and group-chart caches; chartPayloadCached still uses the unchanged data-cache:chart-payload:n100 key. Because the inspected .github/workflows/web-deploy.yml does not invalidate the Data Cache, default requests to /chart/:slug and /api/chart/:slug can keep returning the pre-deploy format-only payload for the 24-hour backstop, while the newly versioned group bundle already shows split modes. Add a version to the standalone chart cache key as well.

Useful? React with 👍 / 👎.

@connortsui20 connortsui20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yolo

@lwwmanning
lwwmanning merged commit d9c299f into develop Aug 27, 2026
4 checks passed
@lwwmanning
lwwmanning deleted the wm/random-access-hot-cold branch August 27, 2026 17:19

This branch was successfully deployed

1 active deployment
preview 615b19c3 Deployed Aug 27, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants