Add test for cloud job status update on ECS wait timeout - #196
Merged
Merged
Conversation
createCloudJob already publishes set_state: 'failure' to the backend whenever the try block throws, including the "waiting for the container to stop" timeout, but nothing verified that path. Add a fake ECS stub that never reports STOPPED plus a stubbed await-sleep so the timeout branch is reached quickly, and assert the failure status is published. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tg4MmT9mM5e1o5sGywRkiq
|
coverage: 71.676% (+0.8%) from 70.906% — claude/cloud-job-timeout-status-o2h1t3 into main |
1 similar comment
|
coverage: 71.676% (+0.8%) from 70.906% — claude/cloud-job-timeout-status-o2h1t3 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.