Skip to content

Add safety margin to ECS container overrides length limit #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriksm merged 2 commits into from
Sep 8, 2026
Merged

Add safety margin to ECS container overrides length limit #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ce1a7c
Lower ECS container overrides trim threshold for headroom
claude Sep 8, 2026
4782b6b
Use a small adjustable safety margin instead of a fixed lower cap
claude Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/createCloudJob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ import * as crypto from 'crypto'
const clusterName = 'violinist-cluster'
// The ECS API rejects a runTask call where the serialized container overrides
// are longer than this, with "Container Overrides length must be at most 8192".
const overridesMaxLength = 8192
// AWS's own accounting can come out a bit stricter than what we compute here,
// so we trim a bit before the hard limit. Adjust this if that gap changes.
const overridesLengthSafetyMargin = 64
const overridesMaxLength = 8192 - overridesLengthSafetyMargin
// The env var we drop if that happens, to give the task a chance of starting.
const skipWhenTooLong = 'private_key'
const sleepWhilePolling = 5000
Expand Down