fix(release): the package version and the tag that installs it must agree - #261
Merged
Merged
Conversation
…gree Tag 1.1.0 was cut at main on 2026-08-13 while pyproject.toml still said 1.0.0. An install from that tag reports the PREVIOUS release, and views-models#294's capability assert reads exactly that number to decide what the installed build can honour. Caught before either launcher pinned, which is the only reason re-pointing the tag is cheap. Third time in this arc a version has been declared in two places with a guard on one copy — the same shape as the appwrite_env docstring edition (#249) and the blob URL sha (#249). So this ships with the guard, not just the bump. TWO CHECKS, IN THE TWO DIRECTIONS THAT DIFFER. `test_a_release_tag_declares_the_version_the_package_declares` fires only when HEAD carries a release tag, and demands the numbers match. Silent on every untagged commit, because firing there would be the false alarm that gets a guard deleted (ADR-014 §3). `test_the_newest_release_tag_is_not_ahead_of_the_declared_version` runs everywhere and is the direction that actually bit: a tag moved and the file did not. The reverse — file ahead of tag — is an ordinary pre-release bump and stays silent. Mutation-proven both ways: reverting the file to 1.0.0 fails with the exact sentence describing what happened today; setting it to 1.2.0 passes. Suite 422 passed / 2 skipped / 40 xfailed, ruff clean. The second skip is the tag check on an untagged HEAD, which is correct here and will run on the re-pointed tag. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag
1.1.0was cut atmaintoday whilepyproject.tomlstill said1.0.0. An install from that tag reports the previous release — and views-models#294's capability assert reads exactly that number to decide what the installed build can honour.Caught before either launcher pinned, which is the only reason re-pointing the tag is cheap.
Why it ships with a guard, not just a bump
Third time in this arc a version has been declared in two places with a check on only one copy — same shape as the
appwrite_envdocstring edition and the blob-URL sha, both fixed in #249.Two checks, in the two directions that differ:
The reverse (file ahead of tag) is an ordinary pre-release bump and stays silent. Firing there would be the false alarm that gets a guard deleted (ADR-014 §3).
Mutation-proven both ways: reverting the file to
1.0.0fails with the exact sentence describing today; setting it to1.2.0passes.After merging
The tag needs re-pointing at the new
main— nothing has pinned to it yet, so the window is clean:The second skip is the tag check on an untagged HEAD — correct here, and it will run once the tag is re-pointed.
🤖 Generated with Claude Code