Skip to content

fixed nil pointer - #59

Open
adranwit wants to merge 339 commits into
master-w-panic-handlingfrom
master
Open

fixed nil pointer#59
adranwit wants to merge 339 commits into
master-w-panic-handlingfrom
master

Conversation

@adranwit

Copy link
Copy Markdown
Contributor

No description provided.

ppoudyal-viant and others added 30 commits November 24, 2025 11:14
add safeMarshal in the logging
ENG-52439: using AppendMetrics with mutex lock; updating logging with…
ENG-51959: using snapshot for logging
vcarey-viant and others added 30 commits July 15, 2026 14:45
bypass internal true for warmup
Improve SQL error logging context
Generated artifacts differed between machines and between runs, so
regenerating produced large spurious diffs. Fix each source of
non-determinism where the unordered data enters the pipeline.

- codegen: run emitted code through go/format and correct the EmbedFS
  snippet indentation. On a format error the unformatted result is kept.
- column discovery: sort information_schema columns by ordinal position.
  Those queries carry no ORDER BY, so driver ordering leaked into
  generated struct field order. Columns inferred from a result set carry
  no position and are left untouched, preserving the projection order the
  query already established.
- route listing: sort paths.yaml entries by URL. The recursive listing
  reflected directory enumeration order, which varies by filesystem and
  shifts whenever route files are rewritten, so partial regeneration
  reshuffled thousands of lines. Route lookup is order independent: the
  matcher builds a trie and prefers exact matches.

Adds unit tests covering each sort and the gofmt stability of generated
output.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…files

ENG-00000: Make generated code and paths.yaml deterministic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.