Fix dynamic promise runtime gating - #117
Open
eli-sterling wants to merge 1 commit into
Open
Conversation
|
@eli-sterling is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| } | ||
| // Promise values crossing the checked-dynamic boundary are boxed by | ||
| // emit-walkers through scr_dyn_new_promise_adapting(). That constructor | ||
| // lives in scr_async_dyn.c, so promise-typed IR must pull that TU in even |
There was a problem hiding this comment.
The moduleUsesDynAsync() promise gate matches every promise-typed IR node, over-linking scr_async_dyn.c into fully-static async programs that never box a promise to dyn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a typed Promise crossed the checked-dynamic boundary, the compiler emitted
scr_dyn_new_promise_adaptingbut did not always link the runtime translation unit defining it.This caused a linker failure for valid programs using typed promises through dynamic callbacks.
Fix
moduleUsesDynAsync()now detects Promise-typed IR values and enables the dynamic Promise runtime support when required.Validation
npx pnpm exec vitest run tests/harness/island.test.ts -t "links the dynamic promise adapter"mainwith the same 418664-byte result, so they are not introduced by this patch.Commit:
27537e0