fix(examples): correct Tailwind @source paths in chat and harness-chat - #313
Open
adhamali450 wants to merge 1 commit into
Open
fix(examples): correct Tailwind @source paths in chat and harness-chat#313adhamali450 wants to merge 1 commit into
adhamali450 wants to merge 1 commit into
Conversation
The chat example never scanned the @json-render/shadcn package, so classes that only occur inside it (grid-cols-4, justify-around, etc.) were missing from the generated CSS. Other examples already scan packages/shadcn/src. This aligns chat with that convention. Also fixes the streamdown @source path in chat and harness-chat. "../../../node_modules" points at the repo root, which is empty under pnpm. Dependencies are linked into each example's own node_modules, as apps/web already assumes.
Contributor
|
@adhamali450 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312
What
examples/chat/app/globals.css: add@source "../../../packages/shadcn/src/**/*.tsx", matchingno-ai,next-website-builder, andmcp, so catalog-only utilities are generatedchatandharness-chat: fix the streamdown@sourcepath from../../../node_modules/...(repo root, empty under pnpm) to../node_modules/..., matchingapps/webWhy
Tailwind v4 skips
node_modulesand gitignoreddistwhen scanning sources, so classes that only exist in the built@json-render/shadcnpackage never reach the generated CSS. AGridwithcolumns: 4renders correct DOM with dead class names.Testing
Prompted the chat example for a 4x4 card grid and a
justify="around"stack.grid-cols-1..6andjustify-aroundnow appear in the served CSS and layouts render correctly.