Skip to content

Fix issue updateSymbolEnds method - #754

Merged
MaximPlusov merged 1 commit into
integrationfrom
symbol-ends
Aug 25, 2026
Merged

Fix issue updateSymbolEnds method#754
MaximPlusov merged 1 commit into
integrationfrom
symbol-ends

Conversation

@LonelyMidoriya

@LonelyMidoriya LonelyMidoriya commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Issue was caused by adding of element to symbolEnds even if length of text value was 0

Summary by CodeRabbit

  • Bug Fixes
    • Corrected handling of zero-length text segments to prevent unintended endpoint changes.
    • Preserved existing endpoint behavior for single-character and longer text segments.

Issue was caused by adding of element to symbolEnds even if length of text value was 0
@LonelyMidoriya LonelyMidoriya self-assigned this Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bcd2e246-c269-4298-a95f-7ecc014fe962

📥 Commits

Reviewing files that changed from the base of the PR and between 2d86a4f and 450eca6.

📒 Files selected for processing (1)
  • wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/TextChunksHelper.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

updateSymbolEnds now ignores zero-length input without modifying symbolEnds. Existing behavior remains for single-length and longer inputs.

Changes

Symbol endpoint handling

Layer / File(s) Summary
Endpoint length branching
wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/TextChunksHelper.java
updateSymbolEnds returns early for zero length. Length one remains a single endpoint case, and longer lengths retain interpolation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 450ec

This is a small, localized fix to prevent empty text values from being added to symbol ends. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: maximplusov

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the affected method and states that the pull request fixes its behavior. It is related to the main change, although it does not specify the zero-length input issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch symbol-ends

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MaximPlusov
MaximPlusov merged commit e94f537 into integration Aug 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants