Skip to content

Fix unbounded recursive embedded-file validation #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximPlusov merged 1 commit into from
Aug 18, 2026
Merged

Fix unbounded recursive embedded-file validation #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions validation-model/src/main/java/org/verapdf/gf/model/impl/external/GFEmbeddedFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,18 @@ public class GFEmbeddedFile extends GFExternal implements EmbeddedFile {
public static final String EMBEDDED_FILE_TYPE = "EmbeddedFile";

private final COSStream stream;
protected String id;

public GFEmbeddedFile(COSStream stream) {
super(EMBEDDED_FILE_TYPE);
this.stream = stream;

if (stream != null) {
COSKey key = stream.getObjectKey();
id = key != null ?
key.getNumber() + " " + key.getGeneration() + " obj " + this.getObjectType()
: super.getID();
}
}

@Override
Expand All @@ -84,6 +92,11 @@ public Boolean getisValidPDFA12() {
public Boolean getisValidPDFA124() {
return isValidPDFA(new HashSet<>(Arrays.asList(PDFAFlavour.PDFA_1_B, PDFAFlavour.PDFA_2_B, PDFAFlavour.PDFA_4)));
}

@Override
public String getID() {
return this.id == null ? super.getID() : this.id;
}

private boolean isValidPDFA(Set<PDFAFlavour> flavours) {
if (this.stream == null) {
Expand Down
Loading