fix: check-pck-expiry checks X.509 cert expiry - #109
Merged
Conversation
The PCK cache blob contains URL-encoded PEM X.509 certificates (PCK certs + Intel SGX CA chain) alongside embedded JSON TCB info. The merged version (PR validatedpatterns#107) only checked TCB nextUpdate (collateral freshness). This adds extraction and checking of the actual X.509 certificate notAfter dates. PCK certs have ~7-year validity; TCB nextUpdate is ~30 days. Both matter: stale TCB causes attestation failures, expired certs break the trust chain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #107. The PCK cache blob stored in
intel-dcap-operator-systemcontains URL-encoded PEM X.509 certificates (PCK certs + Intel SGX CA chain) alongside the embedded JSON TCB info. The version merged in #107 only checked the TCBnextUpdate(collateral freshness), not the actual certificate expiry.This adds extraction and parsing of the X.509 certs so
check-pck-expiry.shreports both:notAfter— PCK certs (~7-year validity) and CA chainnextUpdate— collateral freshness (~30 days)Both are operationally relevant: stale TCB info can cause attestation failures, and expired certs break the trust chain.
Test plan
🤖 Generated with Claude Code