shadow-core: name the package uu_shadow_core, as crates.io knows it - #316
Merged
Merged
Conversation
The library was published as uu_shadow_core (0.2.1) because shadow-core on crates.io belongs to an unrelated project, but the manifest still said shadow-core, so a publish from a checkout could not work and the crates.io copies fell three minor versions behind. The package is now uu_shadow_core; its Rust name stays shadow_core through [lib] name, and every dependant reaches it through the same `shadow-core` dependency key with `package = "uu_shadow_core"`, so no code changes. The fuzz workspace, the lockfile and the two `-p` invocations in ci.yml follow. CONTRIBUTING gains the publish order: the library, the tool crates, the five thin crates that wrap another tool's crate, then the multicall. `cargo publish --dry-run -p uu_shadow_core` packages 32 files; `make check` in the container is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library was published as
uu_shadow_core(0.2.1) becauseshadow-coreon crates.io belongs to an unrelated project, but the manifest still saidshadow-core, so a publish from a checkout could not work. The package is nowuu_shadow_core; its Rust name staysshadow_corethrough[lib] name, and every dependant reaches it through the sameshadow-coredependency key withpackage = "uu_shadow_core", so no code changes. The fuzz workspace, the lockfile and the two-pinvocations in ci.yml follow. CONTRIBUTING gains the publish order.cargo publish --dry-run -p uu_shadow_corepackages 32 files;make checkin the container: 2830 tests, 0 failed.