Makefile: shadow group does not exist on some system

[oech3]

shadow/Makefile

Line 161 in f2fca43

install -Dm2755 -g shadow target/release/$$tool $(DESTDIR)$(BINDIR)/$$tool || exit 1; \

However, it is not valid for Arch https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=uutils-shadow#n24

[pierre-warnier]

Thanks for the report, and for the PKGBUILD. You are right that the group is a Debian convention: Fedora has none either, and make install failed there too.

#309 makes the choice at make time. Where a shadow group exists, expiry is installed 2755 root:shadow as before; where it does not, it is installed 4755 root, which is how Arch and Fedora ship chage, the GNU tool that reads /etc/shadow on a user's behalf. SHADOW_GROUP= names a group under another name.

Worth knowing for the PKGBUILD: the sed in it leaves expiry setgid to the root group, which has no right to read /etc/shadow on Arch, so expiry there works for root only. Once #309 is in a release the sed can go, and expiry will be usable by every user, as on Debian.

[pierre-warnier]

0.5.1 is out with this fix: https://github.com/uutils/shadow/releases/tag/0.5.1. With it, make install on Arch puts expiry and chage at 4755 root, the way Arch ships GNU's chage, so the sed in the PKGBUILD can go and both tools work for every user. Thanks again for the report.